Update code from service worker to module worker format #18139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
a team,
GregBrimble,
RebeccaTamachiro,
ToriLindsay,
WalshyDev,
angelampcosta,
aninibread,
dcpena,
irvinebroque,
mikenomitch,
renandincer,
third774 and
tsmith512
as code owners
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
Deploying cloudflare-docs with
|
| Latest commit: |
ef30a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70889885.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://svc2mod.cloudflare-docs-7ou.pages.dev |
github-actions
bot
assigned
dcpena,
haleycode,
patriciasantaana,
pedrosousa,
renandincer,
third774,
aninibread,
GregBrimble,
irvinebroque and
ToriLindsay
github-actions
bot
added
product:automatic-platform-optimization
product:images
github-actions
bot
added
product:pages
product:ssl
Contributor
irvinebroque
approved these changes
Nov 13, 2024
Contributor
Author
|
@ToriLindsay could you please help get this PR in? semgrep errors are false positive and might be fixable in the UI but I don't have access. Thanks |
ToriLindsay
approved these changes
Nov 14, 2024
Contributor
|
@dcpena @angelampcosta @RebeccaTamachiro Can you approve or confirm that this can be merged since it affects your docs too? |
Contributor
Update: I'm working on getting access and also asking someone on my team for help Update: I can merge as soon as the other PCX writers whose docs are affected confirm. I've also reached out to them via chat. |
dcpena
approved these changes
Nov 14, 2024
angelampcosta
approved these changes
Nov 14, 2024
Contributor
Author
|
Thanks all for the reviews! |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the last workers code snippets using the Service Worker syntax - work started in #17905
@irvinebroque We still have a few snippets using both syntaxes (see the tabs on top):
I'm in favor or dropping the Service Worker syntax from there too:
Thoughts?
/cc @ToriLindsay